Skip to content

feat: UI for promoting next user to admin role (WPB-25278)#4819

Merged
sbakhtiarov merged 2 commits into
developfrom
feat/promote-user-admin-ui
May 18, 2026
Merged

feat: UI for promoting next user to admin role (WPB-25278)#4819
sbakhtiarov merged 2 commits into
developfrom
feat/promote-user-admin-ui

Conversation

@sbakhtiarov
Copy link
Copy Markdown
Contributor

@sbakhtiarov sbakhtiarov commented May 13, 2026 •
edited by github-actions Bot
Loading

https://wearezeta.atlassian.net/browse/WPB-25278

https://wearezeta.atlassian.net/browse/WPB-25278

What's new in this PR?

New dialog for leave conversation options and screen for selecting next admin user.

Screen_recording_20260513_090643.webm

@sbakhtiarov sbakhtiarov requested a review from saleniuk May 13, 2026 07:09
@sbakhtiarov sbakhtiarov requested a review from ohassine May 13, 2026 07:09
@sbakhtiarov sbakhtiarov requested a review from Garzas May 13, 2026 07:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

@sbakhtiarov looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69a608d5126385b2a1284845657c0bbf11f9c65 c7bc36514a75f7398e0f7f85a981561ec1fb023a

Is this intentional?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.17%. Comparing base (0bb1fbf) to head (d9d46e2).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...i/home/conversationslist/model/GroupDialogState.kt 0.00% 6 Missing ⚠️
...onversations/promoteadmin/PromoteAdminViewModel.kt 90.69% 1 Missing and 3 partials ⚠️

❌ Your patch check has failed because the patch coverage (79.59%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4819      +/-   ##
===========================================
+ Coverage    51.11%   51.17%   +0.06%     
===========================================
  Files          610      611       +1     
  Lines        21091    21140      +49     
  Branches      3392     3399       +7     
===========================================
+ Hits         10780    10819      +39     
- Misses        9299     9306       +7     
- Partials      1012     1015       +3
Files with missing lines Coverage Δ
...onversations/promoteadmin/PromoteAdminViewModel.kt 90.69% <90.69%> (ø)
...i/home/conversationslist/model/GroupDialogState.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb1fbf...d9d46e2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbakhtiarov sbakhtiarov force-pushed the feat/promote-user-admin-ui branch from 3e04c2b to 9770588 Compare May 13, 2026 12:53
@sbakhtiarov sbakhtiarov requested a review from saleniuk May 13, 2026 12:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

@sbakhtiarov looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69a608d5126385b2a1284845657c0bbf11f9c65 c7bc36514a75f7398e0f7f85a981561ec1fb023a

Is this intentional?

ohassine
ohassine approved these changes May 13, 2026
View reviewed changes
Comment thread ...src/main/kotlin/com/wire/android/ui/home/conversations/promoteadmin/PromoteAdminViewModel.kt Outdated
@sbakhtiarov sbakhtiarov force-pushed the feat/promote-user-admin-ui branch from 9770588 to 03c563d Compare May 15, 2026 08:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

@sbakhtiarov looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69a608d5126385b2a1284845657c0bbf11f9c65 c7bc36514a75f7398e0f7f85a981561ec1fb023a

Is this intentional?

@sbakhtiarov sbakhtiarov force-pushed the feat/promote-user-admin-ui branch from 03c563d to 61d7105 Compare May 15, 2026 08:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

@sbakhtiarov looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69a608d5126385b2a1284845657c0bbf11f9c65 c7bc36514a75f7398e0f7f85a981561ec1fb023a

Is this intentional?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

@sbakhtiarov looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69a608d5126385b2a1284845657c0bbf11f9c65 ac51876ffcddb1e12b10bdb23aec3d38e6dcdfda

Is this intentional?

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 15, 2026

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sbakhtiarov sbakhtiarov added this pull request to the merge queue May 18, 2026
Merged via the queue into develop with commit 9bbf44c May 18, 2026
18 checks passed
@sbakhtiarov sbakhtiarov deleted the feat/promote-user-admin-ui branch May 18, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Garzas Garzas Garzas approved these changes

@ohassine ohassine ohassine approved these changes

@saleniuk saleniuk Awaiting requested review from saleniuk

Assignees

@sbakhtiarov sbakhtiarov

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbakhtiarov @Garzas @ohassine @saleniuk